-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IConfiguration adapter #365
Fix IConfiguration adapter #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a spec to test this change (handling of case sensitivity)
@@ -15,20 +15,20 @@ namespace Akka.Hosting.Configuration | |||
{ | |||
public static class ConfigurationHoconAdapter | |||
{ | |||
public static Config ToHocon(this IConfiguration config) | |||
public static Config ToHocon(this IConfiguration config, bool normalizeKeys = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…kka.Hosting into Fix_IConfiguration_adapter_2
@Aaronontheweb the spec for case sensitivity is there already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.